[FINERACT-796] Use Hikari instead of Tomcat Connection Pool

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Assignee: Yemdjih Kaze Nasser
• Reporter: Michael Vorburger
• Created: 21/Oct/19 08:03
• Updated: 28/Mar/20 17:01
• Resolved: 28/Mar/20 17:01

Description

In https://github.com/apache/fineract/pull/642 for FINERACT-724, ivan333m said:

New version of spring-boot-starter-data-jpa uses HikariCP as default connection pool instead of tomcat-jdbc. So I need to add this dependency. Also I have excluded HikariCP in the latest commit.

Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc default to HikariCP, and that e.g. https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database explicitly states:

We prefer HikariCP for its performance and concurrency. If HikariCP is available, we always choose it. Otherwise, if the Tomcat pooling DataSource is available, we use it.

I think we should eventually replace our use of the Tomcat JDBC Connection Pool with Hikari.

I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a pre-req. to it.

Issue Links

• relates to: FINERACT-730 Fix failing gradle task bootRun & can't run simple Spring Boot java -jar (without Tomcat)
• relates to: FINERACT-786 Fineract on Google Cloud ("managed", with Cloud SQL)
• relates to: FINERACT-764 Run Integration Tests using Spring Boot IT support instead of on Tomcat started separately by gradle-tomcat-plugin
• links to: GitHub Pull Request #746