Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-796

Use Hikari instead of Tomcat Connection Pool

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: None
    • Labels:
      None

      Description

      InĀ https://github.com/apache/fineract/pull/642 for FINERACT-724, ivan333m said:

      New version of spring-boot-starter-data-jpa uses HikariCP as default connection pool instead of tomcat-jdbc. So I need to add this dependency. Also I have excluded HikariCP in the latest commit.

      Given that both spring-boot-starter-data-jpa and spring-boot-starter-jdbc default to HikariCP, and that e.g. https://docs.spring.io/spring-boot/docs/current/reference/html/spring-boot-features.html#boot-features-connect-to-production-database explicitly states:

      We prefer HikariCP for its performance and concurrency. If HikariCP is available, we always choose it. Otherwise, if the Tomcat pooling DataSource is available, we use it.

      I think we should eventually replace our use of the Tomcat JDBC Connection Pool with Hikari.

      I'm not sure if FINERACT-730 and/or FINERACT-764 will require this, or are a pre-req. to it.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                xurror Yemdjih Kaze Nasser
                Reporter:
                vorburger Michael Vorburger
              • Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 10m
                  10m