[FINERACT-1643] Catch external_id duplicates for loan transactions

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.7.0
• Fix Version/s: 1.8.0
• Component/s: Loan
• Assignee: John Woodlock
• Reporter: John Woodlock
• Created: 20/Jun/22 10:21
• Updated: 22/Aug/22 11:23
• Resolved: 20/Jun/22 15:55

Description

Currently, most loan transactions that allow externalId as an API parameter result in 500 Internal Server Error if externalId is a duplicate.

Credit Balance Refund & 'Adding Loan Charge' do pick-up and test for externalId duplicates but the code that picks these up is itself 'duplicated'.

This improvement is to use a general DataIntegrityErrorHandler method for loan transactions that picks up on JpaSystemException and DataIntegrityViolationException exceptions highlighting duplicate externalIds in particular.

Issue Links

• blocks: FINERACT-1680 Release Apache Fineract 1.8.0
• links to: GitHub Pull Request #2373