[FINERACT-1366] invalid fields in PostClientsClientIdRequest in clientsApiResourceSwagger

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Labels: client gsoc2021 swagger

Language

Java

• Assignee: Danish Jamal
• Reporter: Danish Jamal
• Created: 07/Aug/21 01:40
• Updated: 21/Sep/21 13:46
• Resolved: 21/Sep/21 13:46

Description

Expected body payload while activating the client:

{  
    "activationDate": "02 August 2021", 
    "dateFormat": "dd MMMM yyyy", 
    "locale": "en"
}

Payload model (PostClientsClientIdRequest):

@Schema(description = "PostClientsClientIdRequest")
public static final class PostClientsClientIdRequest {

    private PostClientsClientIdRequest() {}

    @Schema(example = "We cannot accept transfers of clients having loans with less than 1 repayment left")
    public String note;
}

the  PostClientsClientIdRequest must define the required field in order to generate the valid client.
Also officeId field is missing in the returned response while activating a client.

// defined in swagger resource class
@Schema(description = "PostClientsClientIdResponse")
public static final class PostClientsClientIdResponse {

    private PostClientsClientIdResponse() {}

    @Schema(example = "2")
    public Integer clientId;
    @Schema(example = "2")
    public Integer resourceId;
}


// actual json returned
{
  "officeId": 2,
  "clientId": 6,
  "resourceId": 6
}

Issue Links

• links to: GitHub Pull Request #1812