[FINERACT-1330] Pay Charge & withdrawals is violating Overdraft conditions on current and past Transactions

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.3.0, 1.4.0, 1.5.0, 1.6.0, 1.7.0, 1.8.0, 1.9.0
• Fix Version/s: 1.9.0
• Component/s: Charges, Savings
• Assignee: Rahul Pawar
• Reporter: Francis Guchie
• Created: 10/Mar/21 23:48
• Updated: 07/Jan/24 10:55
• Resolved: 23/Aug/22 09:27

Description

To better understand this issue start from FINERACT-1147

Fineract uses future balance to effect transactions thus violating other rules like OVER-DRAFT disabled

• Create a client on 01 Jan 2021
• Apply a savings account on 01 jan 2021 – OVER DRAFT NOT ALLOWED
• Add transactions 4Jan2021 of 50k, 5Jan2021 of 150k and 13 Jan2021 of 500k, 1 Feb2021 of 500k to make a total of 1.2million on the account
• Now make a withdrawal on 29 Jan2021 of 900,000
  1. Fineract should reject this transaction since overdraft not allowed and because 900K > 700k available balance below is the message- this message is in place
• Now let’s add a savings charge of 900,000 due for 29Jan 2021 and pay it up on 29 Jan 2021
• Lets pay the charge on 29Jan 2021
• On submission the charge gets paid getting the Account into Negative on 29Jan 2021 yet this account's Over-draft is disabled

Two issues here

• Overdraft is disabled but the rule has been violated
• Fineract is using real-time balance (in my view) to effect back-dated transactions

 The rule of thumb should be the “balance at transaction date” to be considered during transactions and not available balance

Issue Links

• is a child of: FINERACT-1874 Release Apache Fineract 1.9.0
• links to: GitHub Pull Request #1661
• links to: GitHub Pull Request #2436