[FINERACT-1270] Unify Fineract 3 (!) different email sender utilities

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Assignee: Unassigned
• Reporter: Michael Vorburger
• Created: 28/Nov/20 19:24
• Updated: 13/Mar/21 16:15

Description

While looking into addressing FINERACT-1092, I've just noticed that the Fineract code base has not 1 and not 2 but 3 classes which send email:

• org.apache.fineract.infrastructure.core.service.GmailBackedPlatformEmailService
• org.apache.fineract.infrastructure.campaigns.email.service.EmailMessageJobEmailServiceImpl
• org.apache.fineract.infrastructure.reportmailingjob.service.ReportMailingJobEmailServiceImpl

The best thing is that 2 of those use org.springframework.mail.javamail whereas the 3rd (and probably oldest?) uses org.apache.commons.mail instead.

They, apparently, also use 3 completely different mail server configurations in the database! This doesn't make any sense - I cannot imagine anyone wanting to use 3 different mail server for 3 purposes.

Let's merge all this? Best step by step, in a series of several small PRs, instead of 1 big one. The DB change may also require DB migration scripts to remove the old config (depending on how we want to "migrate").

Issue Links

• blocks: FINERACT-1092 Technical System Parameters should be able to be specfified via environment variables instead of by REST API & DB
• is blocked by: FINERACT-1070 Email Service Configurations defaults to port 25 irrespective of Port number specified
• is related to: FINERACT-1335 Integration Test Email Sending features