[FINERACT-1264] Email Campaigns with Pentaho Reporting Attachments are broken

• Type: Bug
• Status: Open
• Priority: Critical
• Resolution: Unresolved
• Component/s: Reports
• Labels: email
• Assignee: Unassigned
• Reporter: Michael Vorburger
• Created: 21/Nov/20 13:31
• Updated: 09/Apr/21 13:14

Description

While working on FINERACT-1173, I've noticed that org.apache.fineract.infrastructure.campaigns.email.service.EmailCampaignWritePlatformCommandHandlerImpl.generateAttachments(EmailCampaign, ScheduledEmailAttachmentFileFormat, Map<String, String>, String, StringBuilder) use of org.apache.fineract.infrastructure.dataqueries.service.ReadReportingService.generatePentahoReportAsOutputStream(String, String, Map<String, String>, Locale, AppUser, StringBuilder) calls code that is completely commented out.

This was, apparently, broken during the migration from Mifos to Fineract, because of the Pentaho removal.

Fixing that will take a little bit of refactoring. I'd like to do that only after having completed FINERACT-1173 (and FINERACT-1177) and having the 2nd version of https://github.com/vorburger/fineract-pentaho. Once that is done, we can pick this up.

We'll need to change ReportingProcessService to not be tied to javax.ws.rs.core.Response, as Aleks has done in https://github.com/apache/fineract/pull/1416, so that will be part of the answer to fix this. (Although I would suggest that instead of instead of an OutputStream in the Reporting Plugin API we use a com.google.common.io.ByteSource, which can be easily adapted to the org.springframework.core.io.InputStreamSource that org.springframework.mail.javamail.MimeMessageHelper.addAttachment() digs; but that's a detail.)

aleks and ptuomola FYI.

Issue Links

• relates to: FINERACT-1173 Error Message in case of missing reporting implementation is confusing
• relates to: FINERACT-1177 Alt. distro? Spring Boot JAR is not great for "dropping in" Plugins