Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-1201

Remove copy/paste between FileSystemContentRepository and S3ContentRepository

    XMLWordPrintableJSON

Details

    • Bug
    • Status: In Progress
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      While looking into FINERACT-955, I have found that a lot of the code between the FileSystemContentRepository and the S3ContentRepository appear to very similar.. historically most likely copy/pasted from one to the other.

      There are also some subtle differences e.g. FileSystemContentRepository does not seem to invoke ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(), fileName); like S3ContentRepository. I suspect that probably was not intentional?

      Before implementing FINERACT-955, I'll attempt to remove this copy/paste and unify those two implementations of ContentRepository.

      I'll do this in 2 steps: 1. just move some lines, and add some missig lines, to make them "look" more similar; 2. actually merge their code by refactoring into a common abstract super classes or utilities for composition.

      Attachments

        Issue Links

          Activity

            People

              vorburger Michael Vorburger
              vorburger Michael Vorburger
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: