[FINERACT-1201] Remove copy/paste between FileSystemContentRepository and S3ContentRepository

• Type: Bug
• Status: In Progress
• Priority: Major
• Resolution: Unresolved
• Fix Version/s: 3.0.0
• Assignee: Michael Vorburger
• Reporter: Michael Vorburger
• Created: 13/Oct/20 20:52
• Updated: 04/Sep/23 07:31

Description

While looking into FINERACT-955, I have found that a lot of the code between the FileSystemContentRepository and the S3ContentRepository appear to very similar.. historically most likely copy/pasted from one to the other.

There are also some subtle differences e.g. FileSystemContentRepository does not seem to invoke ContentRepositoryUtils.validateFileSizeWithinPermissibleRange(documentCommand.getSize(), fileName); like S3ContentRepository. I suspect that probably was not intentional?

Before implementing FINERACT-955, I'll attempt to remove this copy/paste and unify those two implementations of ContentRepository.

I'll do this in 2 steps: 1. just move some lines, and add some missig lines, to make them "look" more similar; 2. actually merge their code by refactoring into a common abstract super classes or utilities for composition.

Issue Links

• blocks: FINERACT-1224 NullPointerException at Base64$Encoder.encode() in ImagesApiResource
• blocks: FINERACT-1225 In-memory document repository
• blocks: FINERACT-955 ContentRepository for Google Cloud Storage
• is blocked by: FINERACT-1218 Missing Integration Test coverage for Document Management functionality
• requires: FINERACT-1202 S3ContentRepository exception handling and error logging improvements
• links to: GitHub Pull Request #1401
• links to: GitHub Pull Request #1423
• links to: GitHub Pull Request #1424
• links to: GitHub Pull Request #1425
• links to: GitHub Pull Request #1426
• links to: GitHub Pull Request #1427
• links to: GitHub Pull Request #1485