[FINERACT-1124] Return clearer JSON validation errors to clients (instead of HTTP 500)

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Auto Closed
• Labels: Cleanup2022
• Assignee: Unassigned
• Reporter: Michael Vorburger
• Created: 20/Aug/20 15:30
• Updated: 07/Nov/22 18:11
• Resolved: 07/Nov/22 18:11

Description

See FINERACT-932 for general background; on 06.08.20 (only) there were x2 of these in logs of https://www.fineract.dev, which made me think that, in an ideal world, we could catch this and have integrationt tests ensuring that we return clearer JSON validation errors to clients instead of HTTP 500 internal server errors, e.g. in cases like this:

 java.lang.IllegalStateException: Not a JSON Array: "Brasil"

        at com.google.gson.JsonElement.getAsJsonArray (JsonElement.java:107)
        at org.apache.fineract.infrastructure.core.serialization.JsonParserHelper.extractJsonArrayNamed (JsonParserHelper.java:267)
        at org.apache.fineract.infrastructure.core.serialization.FromJsonHelper.extractJsonArrayNamed (FromJsonHelper.java:174)
        at org.apache.fineract.portfolio.client.data.ClientDataValidator.validateForCreate (ClientDataValidator.java:232)
        at org.apache.fineract.portfolio.client.service.ClientWritePlatformServiceJpaRepositoryImpl.createClient (ClientWritePlatformServiceJpaRepositoryImpl.java:231)

Issue Links

• blocks: FINERACT-932 Parent Issue for Error Logs seeing during "normal" usage (e.g. on fineract.dev)