Uploaded image for project: 'Apache Fineract'
  1. Apache Fineract
  2. FINERACT-1101

Swagger CodeGen Test Build using Gradle instead of Maven

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4.0
    • Component/s: SDK
    • Labels:
      None

      Description

      Looking at https://travis-ci.org/github/apache/fineract/builds/714158191 for https://github.com/apache/fineract/pull/1228 for FINERACT-838, I've noticed that the Swagger Client Code Generation seems to be built using Maven mvn... but on docs/developers/swagger/client.md we document the use of Gradle. This seems inconsistent, and requiring Fineract developers to have Maven installed just for this may be unnecessary?

      Chinmay Kulkarni was there a particular reason why you chose to build the client using Maven instead of Gradle on Travis in your PR? If none, would you be willing to raise a PR to change that?

      If that is not possible, the Travis CI should should at least use the Maven Wrapper ./mvnw instead of mvn. And we should add Caching of Maven artifacts in addition to Gradle to the Travis CI configuration, to make it a bit faster.

      Manthan Surkar Petri Tuomola FYI.

        Attachments

        Issue Links

          Activity

            People

            • Assignee:
              aleks Aleksandar Vidakovic
              Reporter:
              vorburger Michael Vorburger

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment