[FINERACT-1029] Failing lint test for static

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Assignee: Natasha Natarajan
• Reporter: Natasha Natarajan
• Created: 09/Jun/20 00:05
• Updated: 15/Jun/20 03:15
• Resolved: 15/Jun/20 03:15

Description

See FINERACT-959 for general background. There is one error and 494 warnings for this failing test.

 

 

/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java:68: warning: [static] static method should be qualified by type name, ClientHelper, instead of by an expression
Integer outcome_client_creation=clientHelper.createClient(requestSpec,responseSpec);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java:73: warning: [static] static method should be qualified by type name, GroupHelper, instead of by an expression
Integer outcome_group_creation=groupHelper.createGroup(requestSpec,responseSpec,true);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java:78: warning: [static] static method should be qualified by type name, StaffHelper, instead of by an expression
Integer outcome_staff_creation =staffHelper.createStaff(requestSpec,responseSpec);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java:91: warning: [static] static method should be qualified by type name, FundsResourceHandler, instead of by an expression
Integer outcome_fund_creation=fundsResourceHandler.createFund(jsonFund,requestSpec,responseSpec);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/loan/LoanWorkbookPopulatorTest.java:99: warning: [static] static method should be qualified by type name, PaymentTypeHelper, instead of by an expression
Integer outcome_payment_creation= paymentTypeHelper.createPaymentType(requestSpec, responseSpec,name,description,isCashPayment,position);
^
error: warnings found and -Werror specified
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java:66: warning: [static] static method should be qualified by type name, ClientHelper, instead of by an expression
Integer outcome_client_creation=clientHelper.createClient(requestSpec,responseSpec);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java:71: warning: [static] static method should be qualified by type name, GroupHelper, instead of by an expression
Integer outcome_group_creation=groupHelper.createGroup(requestSpec,responseSpec,true);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java:76: warning: [static] static method should be qualified by type name, StaffHelper, instead of by an expression
Integer outcome_staff_creation =staffHelper.createStaff(requestSpec,responseSpec);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/savings/SavingsWorkbookPopulateTest.java:81: warning: [static] static method should be qualified by type name, SavingsProductHelper, instead of by an expression
Integer outcome_sp_creaction=savingsProductHelper.createSavingsProduct(jsonSavingsProduct,requestSpec,responseSpec);
^
/fineract/fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/bulkimport/populator/client/ClientEntityWorkbookPopulatorTest.java:65: warning: [static] static method should be qualified by type name, StaffHelper, instead of by an expression
Integer outcome_staff_creation =staffHelper.createStaff(requestSpec,responseSpec);

Issue Links

• is a child of: FINERACT-959 Tighten javac compilerArgs, turn more warnings into errors (and fix related problems)
• links to: GitHub Pull Request #1021