[FILEUPLOAD-341] Move exceptions out of .impl package

• Type: Wish
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.0
• Fix Version/s: 2.0.0
• Assignee: Jochen Wiedmann
• Reporter: Martin Tzvetanov Grigorov
• Created: 20/Aug/21 07:59
• Updated: 14/Sep/21 06:59
• Resolved: 13/Sep/21 18:38

Description

With FILEUPLOAD-340 commons-fileupload2 now provides a module-info.class that exports all packages but org.apache.commons.fileupload2.impl.

 

Would it be OK to move all **Exception classes to the parent package so that they are visible by users ?

**Impl classes should stay in org.apache.commons.fileupload2.impl!

 

In Apache Wicket we use few of the exception classes to report specific errors:

• https://github.com/apache/wicket/blob/43bc9b112ee43fac80f830632415cd8060b3d1a2/wicket-core/src/main/java/org/apache/wicket/protocol/http/servlet/MultipartServletWebRequestImpl.java#L505
• https://github.com/apache/wicket/blob/270a5a43970cd975539331b21a34bd83a59c9c39/wicket-core/src/main/java/org/apache/wicket/markup/html/form/Form.java#L1504

Issue Links

• is related to: FILEUPLOAD-340 Make commons-fileupload a proper JPMS module
• relates to: WICKET-6915 Update common-fileupload to 2.0