[FILEUPLOAD-296] Speed Up Parsing

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Nightly Builds, 2.0.0
• Fix Version/s: 1.4.1
• Labels: perfomance pull-request-available
• Flags: Patch
• Assignee: Jochen Wiedmann
• Reporter: David Georg Reichelt
• Created: 18/Mar/19 09:52
• Updated: 25/Mar/19 14:21
• Resolved: 25/Mar/19 14:21

Description

In 4ed6e923cb2033272fcb993978d69e325990a5aa, FileUploadBase.parseRequest was changed: Instead of using a buffer declared there and passing it to Streams.copy(InputStream, OutputStream , boolean, byte[]), Streams.copy(InputStream, OutputStream , boolean) was used.

This slows down the parsing by ~ 10%: Since in every iteration of the loop a new buffer is created in Streams.copy, additional effort is created. I therefore recommend to create a buffer and reuse it.

Issue Links

• links to: GitHub Pull Request #18