[FILEUPLOAD-293] FileExistsException: Destination .. already exists when DiskFileItem.write was given an existing file

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.4.1
• Assignee: Jochen Wiedmann
• Reporter: Mladen Girazovski
• Created: 21/Feb/19 06:42
• Updated: 13/Jun/22 11:32
• Resolved: 24/Feb/19 14:12

Description

Since 1.4, where FILEUPLOAD-248 was shipped, passing an existing file to DiskFileItem.write will cause an FileExistsException with the message "Destination FILE already exist", this prevents us from upgrading to 1.4 from 1.3.3.

 

2019-02-20 01:12:56,504 http-nio-2990-exec-3 ERROR [|5ccb9b99-a96f-42ba-ad01-ac278516e1a4|] [IssueAttachmentsResource.privacy-safe] Error saving attachment
org.apache.commons.io.FileExistsException: Destination '/buildeng/bamboo-agent-home/xml-data/build-dir/CLOUDRELEASE-AGILEWD15421-FT18/jira-test-runner-jira/target/cargo/configurations/tomcat9x/temp/attachment-3404789743778163937.tmp' already exists
{{ at org.apache.commons.io.FileUtils.moveFile(FileUtils.java:3001)}}
{{ at org.apache.commons.fileupload.disk.DiskFileItem.write(DiskFileItem.java:405)}}
{{ at com.atlassian.plugins.rest.common.multipart.fileupload.CommonsFileUploadFilePart.write(CommonsFileUploadFilePart.java:49)}}
{{ at com.atlassian.jira.rest.v2.issue.IssueAttachmentsResource.getFileFromFilePart(IssueAttachmentsResource.java:175)}}
...

 

Apache Felix also ran into the same bug:
https://issues.apache.org/jira/browse/FELIX-6037 

Issue Links

• causes: FELIX-6037 Commons FileUpload 1.4 breaks bundle uploads
• is duplicated by: FILEUPLOAD-299 Error replacing an existing file using FileItem.write