[FILEUPLOAD-252] DiskFileItem#write can lose original IO error

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4
• Assignee: Unassigned
• Reporter: Sebb
• Created: 17/Feb/14 23:16
• Updated: 05/Feb/19 14:11
• Resolved: 11/Nov/14 20:45

Description

The method DiskFileItem#write has the following code:

FileOutputStream fout = null;
try {
    fout = new FileOutputStream(file);
    fout.write(get());
} finally {
    if (fout != null) {
        fout.close();
    }
}

If the write fails and then the close fails, the write failure will be masked by the close error. It might be better to write the code as:

FileOutputStream fout = null;
try {
    fout = new FileOutputStream(file);
    fout.write(get());
    fout.close();
} finally {
    IOUtils.closeQuietly(fout);
}

This would ensure that the first error was reported.