[FILEUPLOAD-134] A factory-created DiskFileItem does not have an initialized dfos, causing NullPointerExceptions if getOutputStream() is not called.

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2
• Fix Version/s: 1.2.1
• Assignee: Unassigned
• Reporter: Thomas Vandahl
• Created: 10/Apr/07 15:46
• Updated: 06/Jun/17 04:29
• Resolved: 07/Jun/07 00:06

Description

When upgrading the Turbine code to commons-fileupload 1.2, I got NPEs in Unit tests dealing with DiskFileItems. In that special case, a FileItem was created like this:

ParameterParser pp = new DefaultParameterParser();
DiskFileItemFactory factory = new DiskFileItemFactory(10240, new File("."));

FileItem test = factory.createItem("upload-field", "application/octet-stream", false, null);

pp.add("upload-field", test);

assertTrue(pp.toString().startsWith("{upload-field=[name=null"));

pp.toString() causes a call to test.toString() which (among other things) calls dfos.getFile(). This fails because dfos is not initialized before getOutputStream() is called.

Issue Links

• is duplicated by: FILEUPLOAD-190 NPE in DiskFileItem#getStoreLocation()