[FILEUPLOAD-109] MultipartStream.discardBodyData() implementation is redundant.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.1 Final
• Assignee: Unassigned
• Reporter: Amichai Rothman
• Created: 19/May/06 07:01
• Updated: 10/Jun/06 02:15
• Resolved: 10/Jun/06 02:15

Description

MultipartStream.discardBodyData() is identical to readBodyData() - copied and pasted, but with output removed.

discardBodyData() can be changed to call readBodyData() with a NullInputStream (from commons io package, which is already a dependency). This is much more readable and maintainable, and much less error prone.

(Alternatively, readBodyData() can be modified to handle a null output stream by performing a null check before writing into it, and skipping the writes if output is null. then discardBodyData() can call it with a null argument. However, the first solution seems more elegant.)