Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: gogo-0.2.0
    • Component/s: Gogo Runtime
    • Labels:
      None

      Description

      Source code donation for the OSGi Shell proposal

      1. shell.zip
        49 kB
        Peter Kriens
      2. dwb.patch.gz
        8 kB
        Derek Baum

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Closed Closed
        124d 7h 1 Guillaume Nodet 22/Jun/09 16:24
        Derek Baum made changes -
        Fix Version/s gogo-0.2.0 [ 12314211 ]
        Guillaume Nodet made changes -
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Guillaume Nodet added a comment -

        Closing this issue since the code has been imported and patch applied.
        I've created a gogo component to raise issue for this specific component.

        Show
        Guillaume Nodet added a comment - Closing this issue since the code has been imported and patch applied. I've created a gogo component to raise issue for this specific component.
        Guillaume Nodet made changes -
        Component/s Gogo [ 12312919 ]
        Hide
        Guillaume Nodet added a comment -

        The ICLA is on file, so I'll go ahead an apply the patch.

        Show
        Guillaume Nodet added a comment - The ICLA is on file, so I'll go ahead an apply the patch.
        Hide
        Richard S. Hall added a comment -

        Thanks. I will try to get to the patch when the ICLA is recorded.

        Show
        Richard S. Hall added a comment - Thanks. I will try to get to the patch when the ICLA is recorded.
        Derek Baum made changes -
        Attachment dwb.patch.gz [ 12410440 ]
        Hide
        Derek Baum added a comment -

        attached patches mentioned in my previous comment.

        The patch was created by copying my changes over a fresh checkout of http://svn.apache.org/repos/asf/felix/trunk/gogo and then running 'svn diff'.

        The patched files are also annotated with my name 'derek' and the DWBx bug numbers mentioned in previous comment.

        I have just submitted my ICLA to secretary@apache.org

        Show
        Derek Baum added a comment - attached patches mentioned in my previous comment. The patch was created by copying my changes over a fresh checkout of http://svn.apache.org/repos/asf/felix/trunk/gogo and then running 'svn diff'. The patched files are also annotated with my name 'derek' and the DWBx bug numbers mentioned in previous comment. I have just submitted my ICLA to secretary@apache.org
        Hide
        Richard S. Hall added a comment -

        I have committed the initial contribution of the OSGi shell to our repository under the name "gogo" for the time being. It still needs to have its packages renamed and be put into the proper subproject structure.

        I was thinking that before we do that, that if Derek wants to supply his patches, we can apply those first. Derek, I assume these are all small patches, but given the number of them it might be nice if you have an ICLA on file. Do you? If so, could you attach a patch to this issue?

        Show
        Richard S. Hall added a comment - I have committed the initial contribution of the OSGi shell to our repository under the name "gogo" for the time being. It still needs to have its packages renamed and be put into the proper subproject structure. I was thinking that before we do that, that if Derek wants to supply his patches, we can apply those first. Derek, I assume these are all small patches, but given the number of them it might be nice if you have an ICLA on file. Do you? If so, could you attach a patch to this issue?
        Hide
        Richard S. Hall added a comment -

        We are working on getting this into SVN, we need to go through IP clearance. Hopefully, this will all be done in a week or so, then we can move forward with patches. I think we will need to rename some packages and whatnot. Perhaps we should apply the patches before doing so.

        Show
        Richard S. Hall added a comment - We are working on getting this into SVN, we need to go through IP clearance. Hopefully, this will all be done in a week or so, then we can move forward with patches. I think we will need to rename some packages and whatnot. Perhaps we should apply the patches before doing so.
        Hide
        Derek Baum added a comment -

        I have been working with this code and have made several bug fixes:

        I can supply these as a diff against shell.zip attached to this issue, or when the code is loaded in SVN, I could raise issues against each of the bugs.

        Here is a brief list of the fixes I've made:

        ./aQute/shell/osgi/OSGiCommands.java: // DWB1: osgi:each too verbose (formats results to System.out)
        ./aQute/shell/osgi/OSGiCommands.java: // DWB2: ClassNotFoundException should be caught in convert() method
        ./aQute/shell/osgi/OSGiShell.java: // DWB3: dynamically load optional framework components to reduce dependencies
        ./aQute/shell/osgi/OSGiShell.java: // DWB4: get() with trailing colon causes org.osgi.framework.InvalidSyntaxException
        ./aQute/shell/runtime/Closure.java: // DWB5: session.err is not redirected when creating pipeline
        ./aQute/shell/runtime/Closure.java: // DWB6: add 'set -x' trace feature if echo is set
        ./aQute/shell/runtime/Closure.java: // DWB7: removing variable via 'execute("name=") throws OutOfBoundsException
        ./aQute/shell/runtime/CommandSessionImpl.java: // DWB8: throw IllegatlStateException if session used after closed (as per rfc132)
        ./aQute/shell/runtime/CommandSessionImpl.java: // DWB9: there is no API to list all variables: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
        ./aQute/shell/runtime/CommandSessionImpl.java: // DWB10: add SCOPE support: https://www.osgi.org/bugzilla/show_bug.cgi?id=51
        ./aQute/shell/runtime/CommandShellImpl.java: // DWB11: add removeCommand: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
        ./aQute/shell/runtime/CommandShellImpl.java: // DWB12: there is no API to list commands: https://www.osgi.org/bugzilla/show_bug.cgi?id=49
        ./aQute/shell/runtime/CommandShellImpl.java: // DWB13: addCommand() fails to add static methods (if target is Class)
        ./aQute/shell/runtime/Parser.java: // DWB14: parser loops if // comment at start of program
        ./aQute/shell/runtime/Parser.java: // DWB15: allow program to have trailing ';'
        ./aQute/shell/runtime/Pipe.java: // DWB16: redirect System.err when creating pipe
        ./aQute/shell/runtime/Reflective.java: // DWB16: coerce() doesn't support static methods
        ./aQute/shell/runtime/Reflective.java: // DWB17: coerce() doesn't support static void main(String[]) in rfc132
        ./aQute/shell/runtime/Reflective.java: // DWB18: coerce() doesn't extract cause from InvocationTargetException
        ./aQute/shell/runtime/Reflective.java: // DWB19: coerce() won't add empty array to satisfy Object[] argument
        ./aQute/threadio/ThreadIOImpl.java: // DWB20: ThreadIO should check and reset IO if something (e.g. jetty) overrides

        Show
        Derek Baum added a comment - I have been working with this code and have made several bug fixes: I can supply these as a diff against shell.zip attached to this issue, or when the code is loaded in SVN, I could raise issues against each of the bugs. Here is a brief list of the fixes I've made: ./aQute/shell/osgi/OSGiCommands.java: // DWB1: osgi:each too verbose (formats results to System.out) ./aQute/shell/osgi/OSGiCommands.java: // DWB2: ClassNotFoundException should be caught in convert() method ./aQute/shell/osgi/OSGiShell.java: // DWB3: dynamically load optional framework components to reduce dependencies ./aQute/shell/osgi/OSGiShell.java: // DWB4: get() with trailing colon causes org.osgi.framework.InvalidSyntaxException ./aQute/shell/runtime/Closure.java: // DWB5: session.err is not redirected when creating pipeline ./aQute/shell/runtime/Closure.java: // DWB6: add 'set -x' trace feature if echo is set ./aQute/shell/runtime/Closure.java: // DWB7: removing variable via 'execute("name=") throws OutOfBoundsException ./aQute/shell/runtime/CommandSessionImpl.java: // DWB8: throw IllegatlStateException if session used after closed (as per rfc132) ./aQute/shell/runtime/CommandSessionImpl.java: // DWB9: there is no API to list all variables: https://www.osgi.org/bugzilla/show_bug.cgi?id=49 ./aQute/shell/runtime/CommandSessionImpl.java: // DWB10: add SCOPE support: https://www.osgi.org/bugzilla/show_bug.cgi?id=51 ./aQute/shell/runtime/CommandShellImpl.java: // DWB11: add removeCommand: https://www.osgi.org/bugzilla/show_bug.cgi?id=49 ./aQute/shell/runtime/CommandShellImpl.java: // DWB12: there is no API to list commands: https://www.osgi.org/bugzilla/show_bug.cgi?id=49 ./aQute/shell/runtime/CommandShellImpl.java: // DWB13: addCommand() fails to add static methods (if target is Class) ./aQute/shell/runtime/Parser.java: // DWB14: parser loops if // comment at start of program ./aQute/shell/runtime/Parser.java: // DWB15: allow program to have trailing ';' ./aQute/shell/runtime/Pipe.java: // DWB16: redirect System.err when creating pipe ./aQute/shell/runtime/Reflective.java: // DWB16: coerce() doesn't support static methods ./aQute/shell/runtime/Reflective.java: // DWB17: coerce() doesn't support static void main(String[]) in rfc132 ./aQute/shell/runtime/Reflective.java: // DWB18: coerce() doesn't extract cause from InvocationTargetException ./aQute/shell/runtime/Reflective.java: // DWB19: coerce() won't add empty array to satisfy Object[] argument ./aQute/threadio/ThreadIOImpl.java: // DWB20: ThreadIO should check and reset IO if something (e.g. jetty) overrides
        Hide
        Peter Kriens added a comment -

        MD5 Checksum 9de77d0fef4caff5bb2cf3943a224e98

        Show
        Peter Kriens added a comment - MD5 Checksum 9de77d0fef4caff5bb2cf3943a224e98
        Peter Kriens made changes -
        Field Original Value New Value
        Attachment shell.zip [ 12400396 ]
        Peter Kriens created issue -

          People

          • Assignee:
            Marcel Offermans
            Reporter:
            Peter Kriens
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development