[FELIX-907] Regression in latest BND code: negated exports are applied to private packages

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: maven-bundle-plugin-2.0.0
• Component/s: Maven Bundle Plugin
• Assignee: Peter Kriens
• Reporter: Stuart McCulloch
• Created: 29/Jan/09 11:00
• Updated: 12/Mar/09 08:05
• Resolved: 02/Feb/09 10:04

Description

The latest version of the Bnd Tool has a bug where it combines the Export-Package instructions with the Private-Package instructions:

all.putAll(replaceWitInstruction(getHeader(EXPORT_PACKAGE),
EXPORT_PACKAGE));

all.putAll(replaceWitInstruction(getHeader(PRIVATE_PACKAGE),
PRIVATE_PACKAGE));

this ordering means that any negated packages in Export-Package are erroneously applied to the list of packages in Private-Package.

For example, when you have instructions like the following:

<Export-Package>!org.foo.internal.,org.foo.</Export-Package>
<Private-Package>org.foo.internal.*</Private-Package>

the Bnd Tool will end up excluding the internal packages from the final bundle.

Reversing the statements to be:

all.putAll(replaceWitInstruction(getHeader(PRIVATE_PACKAGE),
PRIVATE_PACKAGE));

all.putAll(replaceWitInstruction(getHeader(EXPORT_PACKAGE),
EXPORT_PACKAGE));

appears to fix the problem, although you could then have problems with negated packages in the Private-Package affecting the Export-Package - but this is less likely.