[FELIX-6591] Memory leak in Felix Framework Security extension

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: framework.security-2.8.3
• Fix Version/s: framework.security-2.8.4
• Component/s: Framework Security
• Labels: MemoryLeak memory-leak
• External issue URL: https://github.com/apache/felix-dev/pull/193

Language

Java

• Assignee: Karl Pauls
• Reporter: Chris Rankin
• Created: 06/Feb/23 15:08
• Updated: 02/May/23 22:20
• Resolved: 14/Apr/23 21:11

Description

Our project loads and unloads a lot of bundles over time, and we have noticed that the JVM quickly spends the majority of its time collecting its garbage.

We have identified the Framework Security extension as one source of this problem. Specifically, the suspiciously large number of Conditions and Permissions objects in every heap dump.

The Permissions objects are definitely leaking because Permission.Entry.hashCode() should use Arrays.hashCode(entry) instead of entry.hashCode() when entry is an array.

I have also reimplemented Conditions to listen for BundleEvent.UNINSTALLED instead of relying on multiple WeakHashMaps. This is consistent with a TODO comment for this class, and allows the Conditions objects to be deleted immediately instead of waiting for the garbage collector to realise that they are no longer referenced.

Issue Links

• links to: GitHub Pull Request #193