[FELIX-6533] Felix released as milestone version cannot parse it's own version id

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: framework-7.0.3
• Fix Version/s: framework-7.0.4
• Component/s: Framework
• Labels: patch-available patch-with-test
• Flags: Patch, Important
• Assignee: Karl Pauls
• Reporter: David Matějček
• Created: 19/May/22 12:23
• Updated: 25/May/22 14:41
• Resolved: 19/May/22 22:01

Description

We tried to prerelease a custom built version for GlassFish, but it it not able to start now. The version id was 7.0.4-omnifish-M1; Felix changed it to 7.0.4.omnifish.M1 on startup and then crashed, because dots are not allowed in classifier.

Cause

I found that it tries to "cleanup" the Maven version, but does it wrong and then tries to parse the result again which fails.

Solution

I am creating PR right after this issue. Felix already has the correct implementation usable for this, so I just moved it to the new VersionConverter class, updated all references and also extended tests. It is backward compatible despite the bit of refactoring.

Issue Links

• links to: GitHub Pull Request #152