Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-6529

Improve memory usage ManifestParser using String deduplication

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • framework-7.0.4
    • None
    • None

    Description

      In my heap dump I've seen a lot of duplicate Strings produced by the ManifestParser.
      It creates a lot of equal strings for the keys in the manifest but doesn't deduplicate them and they're hold forever producing a lot on retained heap.

      I've patched the ManifestParser to deduplicate just the keys and could save ~8 Megs of heap.

      Total usage before: 38MB after: 30MB

      Duplicated Strings before:

      Duplicated Strings after:

      See patch attached.

      Attachments

        1. ManifestParser.patch
          2 kB
          Johannes Edmeier
        2. image-2022-05-13-14-17-55-965.png
          96 kB
          Johannes Edmeier
        3. image-2022-05-13-14-16-39-509.png
          90 kB
          Johannes Edmeier

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            karlpauls Karl Pauls
            jedmeier Johannes Edmeier
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment