[FELIX-6030] @Header in gogo.jline causing maven-bundle-plugin failure

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: gogo.jline-1.1.2
• Fix Version/s: gogo.jline-1.1.4
• Component/s: Gogo JLine
• Assignee: Jean-Baptiste Onofré
• Reporter: Jean-Baptiste Onofré
• Created: 16/Jan/19 14:04
• Updated: 18/Mar/24 09:31
• Resolved: 22/Jan/19 14:56

Description

In the https://svn.apache.org/viewvc?view=revision&revision=1849343 revision, Gogo JLine bundle Activator now contains:

@Header(name = Constants.BUNDLE_ACTIVATOR, value = "${@class}")

In Karaf, we "wrap" gogo.jline in Karaf shell.core:

            <plugin>
                <groupId>org.apache.felix</groupId>
                <artifactId>maven-bundle-plugin</artifactId>
                <configuration>
                    <instructions>
                        <Import-Package>
                            org.osgi.service.event;resolution:=optional,
                            org.apache.karaf.branding;resolution:=optional,
                            !org.apache.felix.gogo.jline*,
                            !org.apache.sshd.*,
                            *   
                        </Import-Package>
                        <Export-Package>
                            org.apache.karaf.shell.api.*;version=${project.version},
                            org.apache.karaf.shell.support.*;version=${project.version},
                            org.apache.felix.service.command,
                            org.apache.felix.service.threadio
                        </Export-Package>
                        <Private-Package>
                            org.apache.karaf.service.guard.tools,
                            org.apache.karaf.shell.impl.*,
                            org.apache.karaf.util,
                            org.apache.karaf.util.filesstream,
                            org.apache.karaf.util.jaas,
                            org.apache.karaf.util.tracker,
                            org.apache.felix.utils.properties,
                            org.apache.felix.utils.extender,
                            org.apache.felix.utils.manifest,
                            org.apache.felix.gogo.jline,
                            org.apache.felix.gogo.runtime,
                            org.apache.felix.gogo.runtime.threadio,
                            org.apache.felix.service.command,
                            org.apache.felix.service.threadio,
                        </Private-Package>
                        <Provide-Capability>
                            osgi.service;effective:=active;objectClass=org.apache.karaf.shell.api.console.SessionFactory
                        </Provide-Capability>
                        <Bundle-Activator>
                            org.apache.karaf.shell.impl.console.osgi.Activator
                        </Bundle-Activator>
                        <Main-Class>
                            org.apache.karaf.shell.impl.console.standalone.Main
                        </Main-Class>
                    </instructions>
                    <unpackBundle>true</unpackBundle>
                </configuration>
            </plugin>

Since the introduction of @Header in Felix Gogo JLine, the build fails with:

[ERROR] Bundle org.apache.karaf.shell:org.apache.karaf.shell.core:bundle:4.2.3-SNAPSHOT : The Bundle-Activator header only supports a single type. The following types were found: org.apache.karaf.shell.impl.console.osgi.Activator,org.apache.felix.gogo.jline.Activator. This usually happens when a macro resolves to multiple types
[ERROR] Error(s) found in bundle configuration

rotty3000 do you know a workaround in the maven-bundle-plugin about that ? If not, do you mind if I remove @Header from Gogo JLine Activator ?

Thanks.
JB

Issue Links

• blocks: KARAF-6096 Upgrade to Felix Gogo 1.1.4
• links to: GitHub Pull Request #167