Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-5850

ResourceBuilder should do deal with null bundle manifest version

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Not A Problem
    • None
    • None
    • Utils
    • None

    Description

      The ResourceBuilder#doBuild should deal with empty (null) bundle manifest version.

      We should do:

          private static String getBundleManifestVersion(Map<String, String> headerMap) {
              return headerMap.get(Constants.BUNDLE_MANIFESTVERSION);
          }
      
         ...
      
                 // Verify that only manifest version 2 is specified.
              String manifestVersion = getBundleManifestVersion(headerMap);
              if (!"2".equals(manifestVersion)) {
                  throw new BundleException("Bundle-ManifestVersion must be 2 but is: " + manifestVersion);
              }
      
      
      

      I will provide a PR (and test with Karaf itest).

      Attachments

        Issue Links

          Activity

            People

              jbonofre Jean-Baptiste Onofré
              jbonofre Jean-Baptiste Onofré
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: