Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-5832

ConfigInstaller should only handle events for configurations it manages

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: fileinstall-3.6.0, fileinstall-3.6.2
    • Fix Version/s: fileinstall-3.6.6
    • Component/s: File Install
    • Labels:
      None
    • Flags:
      Patch

      Description

      Recent changes introduced by FELIX-5609 have caused ConfigInstaller to incorrectly write configuration objects which it does not manage to disk.

      For example, given:

      felix.fileinstall.filter=.*\\.cfg|.*\\.json

      and a CustomConfigInstaller implementing the ArtifactInstaller and ConfigurationListener interfaces for .json configuration files, the expectation is that .cfg files will be installed and written back to disk by Felix's ConfigInstaller.  Any .json configuration files will be installed and written to disk by the CustomConfigInstaller. Unfortunately since FileInstall 3.6.0, .json config files written to disk by the CustomConfigInstaller are overwritten by Felix's own ConfigInstaller.

      The regression is caused by a change to the ConfigInstaller, whereby ConfigurationEvents for all configuration objects are handled as apposed to previous behaviour where only those configuration objects managed by the Felix ConfigInstaller (aka .cfg and .config) are managed.

        Attachments

        1. ConfigInstaller.diff
          1 kB
          Chris Drake

          Issue Links

            Activity

              People

              • Assignee:
                gnodet Guillaume Nodet
                Reporter:
                cgdrake Chris Drake
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: