[FELIX-583] org.apache.felix.webconsole.internal.compendium.ConfigManager.listConfigurations(): ManagedServiceFactory instances are listed twice: with pid and factoryPid

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: webconsole-1.2.0
• Component/s: Web Console
• Assignee: Felix Meschberger
• Reporter: Dieter Wimberger
• Created: 01/Jun/08 04:43
• Updated: 07/Aug/08 07:26
• Resolved: 07/Aug/08 07:26

Description

ManagedServiceFactory instances are listed twice, with pid and factoryPid in org.apache.felix.webconsole.internal.compendium.ConfigManager.listConfigurations().

The factoryPid will be added by the loop over the ServiceReference instances obtained from the framework for the type (class) ManagedServiceFactory:
// find all ManagedServiceFactories to get the factoryPIDs
ServiceReference[] refs = this.getBundleContext().getServiceReferences(ManagedServiceFactory.class.getName(), null );
for ( int i = 0; refs != null && i < refs.length; i++ )

Given that it is not removed from the map metaDataPids, it will also be added as "pid" by the loop:
if ( !metaDataPids.isEmpty() )
{
for ( Iterator mdpi = metaDataPids.entrySet().iterator(); mdpi.hasNext(); )
....

SVN revision 662145.

A fix for this problem is to consistently remove the identifier from metaDataPids; this is done in some cases using:
// remove from the list of known pids
metaDataPids.remove( pid );