[FELIX-5426] Remove callbacks aren't called for optional dependencies in a "circular" dependency scenario

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: org.apache.felix.dependencymanager-r8
• Fix Version/s: org.apache.felix.dependencymanager-r9
• Component/s: Dependency Manager
• Assignee: Pierre De Rop
• Reporter: Dobias van Buuren
• Created: 25/Nov/16 08:33
• Updated: 28/Nov/16 10:43
• Resolved: 28/Nov/16 10:43

Description

In some cases, the whiteboard pattern remove callbacks aren't called by the depenency manager.

See attached test class. Here some sort of "cyclic" dependency is made between 'Shop' -> 'Item' -> 'Shop'.

See the log when starting and stopping a bundle with the attached Activator.java for an example.

Some investigation pointed us to ComponentImpl line 1191:

if (dc.isRequired()) {
	invokeCallbackSafe(dc, EventType.REMOVED, e);
}

When removing the condition for the required dependency, the REMOVED callbacks are called!

Why is the above condition written in the ComponentImpl.java? Can you please investigate this?