Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-5396

Move Sling annotations to dedicated artifact

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: scr annotations 1.12.0
    • Fix Version/s: None
    • Component/s: SCR Tooling
    • Labels:
      None

      Description

      Currently both the Felix SCR and the custom Sling annotations live in the same JAR. In my projects I don't want to use Felix SCR annotation since OSGi 6 defined now its own annotations for components and metatypes (being evaluated by bnd), but still the custom Sling annotations are useful. For that it would be helpful to just declare a dependency to the Sling annotations (and let them process with maven-scr-plugin or scr-bnd-plugin) without polluting my classpath with the Felix SCR annotations. Probably at the same time it makes more sense to maintain the Sling specific annotations and generator in Sling rather than in Felix.

        Issue Links

          Activity

          Hide
          sseifert@pro-vision.de Stefan Seifert added a comment -

          and the separate bundle for the sling-only SCR annotations should be part of the sling project.
          i suppose they are only part of the felix project because long time ago there was no possibility to add custom annotations via an SPI to the SCR generator.

          and the sling SCR annotations may have be refactored on the way to use the same "style" as the new OSGi annotations. e.g. defining the properties with a string array attribut instead of separate @Property/@Properties annotations - otherwise you still need (part) of the Felix SCR annotations.

          Show
          sseifert@pro-vision.de Stefan Seifert added a comment - and the separate bundle for the sling-only SCR annotations should be part of the sling project. i suppose they are only part of the felix project because long time ago there was no possibility to add custom annotations via an SPI to the SCR generator. and the sling SCR annotations may have be refactored on the way to use the same "style" as the new OSGi annotations. e.g. defining the properties with a string array attribut instead of separate @Property/@Properties annotations - otherwise you still need (part) of the Felix SCR annotations.
          Hide
          cziegeler Carsten Ziegeler added a comment -

          RFC 222 (Declarative Service R7) is currently in the process to define a way to allow 3rd party annotations.
          So we could have our @SlingServlet annotation which sets the according properties
          I think we should wait for the outcome of that

          Show
          cziegeler Carsten Ziegeler added a comment - RFC 222 (Declarative Service R7) is currently in the process to define a way to allow 3rd party annotations. So we could have our @SlingServlet annotation which sets the according properties I think we should wait for the outcome of that

            People

            • Assignee:
              Unassigned
              Reporter:
              kwin Konrad Windszus
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:

                Development