[FELIX-5373] Improve failure message when enabling metatype and using no or private properties only

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: maven-scr-plugin 1.22.0
• Fix Version/s: maven-scr-plugin 1.23.0, scr ant task 1.16.0, scr generator 1.15.0, scr bnd plugin 1.6.0
• Component/s: SCR Tooling
• Assignee: Carsten Ziegeler
• Reporter: Oliver Lietz
• Created: 07/Oct/16 18:15
• Updated: 18/Oct/16 04:59
• Resolved: 12/Oct/16 19:21

Description

@Component(
    label = "Foo",
    description = "SCR Foo Service",
    metatype = true
)
@Service
@Properties({
    @Property(
        name = Constants.SERVICE_VENDOR,
        value = "Example"
    ),
    @Property(
        name = Constants.SERVICE_DESCRIPTION,
        value = "service doing foo"
    )/*,
    @Property(
        name = "foo",
        value = "bar"
    )*/
})
public class ScrFooService implements FooService {

    public void foo() {
    }

}

metatype = false (or not set):

[WARNING] /[...]/ScrFooService.java [1:1]:  Component org.apache.felix.FELIX_5373.internal.ScrFooService has set a label. However metatype is set to false. This label is ignored.
[WARNING] /[...]/ScrFooService.java [1:1]:  Component org.apache.felix.FELIX_5373.internal.ScrFooService has set a description. However metatype is set to false. This description is ignored.

metatype = true:

[ERROR] /[...]/ScrFooService.java [1:1]: @Component : Component is defined to generate metatype information, however no properties have been defined; in case no properties are wanted, consider to use 'metatype=false'

The build succeeds only without warnings when adding a non-private property (where it should also succeed with private properties only).

Issue Links

• is related to: FELIX-5308 Inconsistent Validation with Metatype Container
• is related to: FELIX-4033 Issue warning messages for redundant SCR annotation combinations and an error for declaring the service.id property
• is related to: FELIX-4035 Issue warning messages when metatype is be created, but no properties are defined