[FELIX-5371] ComponentDescriptorIO.java relies on XML tags order

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: scr generator 1.14.0
• Fix Version/s: maven-scr-plugin 1.23.0, scr ant task 1.16.0, scr generator 1.15.0, scr bnd plugin 1.6.0
• Component/s: SCR Tooling
• Assignee: Carsten Ziegeler
• Reporter: Sergey Bondarenko
• Created: 07/Oct/16 14:50
• Updated: 18/Oct/16 04:58
• Resolved: 13/Oct/16 05:38

Description

The parser relies implicitly on an order of tags in a component descriptor XML.
https://github.com/apache/felix/blob/1efe76fff7f4dcc5da5aa450ee8e7a774c874256/tools/org.apache.felix.scr.generator/src/main/java/org/apache/felix/scrplugin/xml/ComponentDescriptorIO.java#L546

                } else if (localName.equals(IMPLEMENTATION)) {
                    ...
                    this.currentClass = new ClassDescription(cl, "classpath:" + className);
                    ...
                } else if (localName.equals(SERVICE)) {

                    this.currentService = new ServiceDescription(null);
                    this.currentClass.add(this.currentService);

This chunk of code expects <implementation> tag to happen before <service> tag. If the order is reversed, then parsing files with NullPointerException when trying to call "add" on an uninitialized variable.