Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-5217

Fileinstall is handling removal of many files inefficiently

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: fileinstall-3.5.4
    • Component/s: File Install
    • Labels:
      None

      Description

      I am currently debugging a performance issue with file install.

      The thread is very hot on:
      java.util.HashMap.hash(java.lang.Object)
      java.util.HashMap.put(java.lang.Object, java.lang.Object)
      java.util.HashSet.add(java.lang.Object)
      java.util.AbstractCollection.addAll(java.util.Collection) (line: 344)
      org.apache.felix.fileinstall.internal.WatcherScanner.scan(boolean) (line: 100)
      org.apache.felix.fileinstall.internal.DirectoryWatcher.run() (line: 302)

      What I see in WatcherScanner, is that it potentially adds the same elements over and over again.
      While I am sure that this is not the root cause, I suggest to change the method to avoid this. (submitting pr in a second)

        Attachments

          Activity

            People

            • Assignee:
              gnodet Guillaume Nodet
              Reporter:
              fabianlange Fabian Lange
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: