[FELIX-5199] Race condition in HttpServiceFactory.getService() causing exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: http.base-3.0.6, http.jetty-3.1.6, http.bridge-3.0.6
• Fix Version/s: http.base-3.0.8, http.jetty-3.2.0, http.bridge-3.0.8
• Component/s: HTTP Service
• Assignee: David Bosschaert
• Reporter: David Bosschaert
• Created: 25/Feb/16 18:34
• Updated: 01/Apr/16 07:40
• Resolved: 23/Mar/16 06:55

Description

The HttpServiceFactory.getService() is as follows:

    public HttpService getService(final Bundle bundle, final ServiceRegistration<HttpService> reg)
    {
        final ServletContext servletContext = this.context;
        if ( servletContext != null ) {
            return new PerBundleHttpServiceImpl(bundle,
                    this.sharedHttpService,
                    this.context,
                    this.contextAttributeListenerManager,
                    this.sharedContextAttributes,
                    this.requestListenerManager,
                    this.requestAttributeListenerManager);
        }
        return null;
    }

However it is possible that this.context is set to null after the check for null is done but before the constructor is called causing a null servlet context to be passed to PerBundleHttpServiceImpl