[FELIX-4848] Split ResolverImpl

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Affects Version/s: resolver-1.0.0
• Component/s: Resolver
• Flags: Patch
• Assignee: Unassigned
• Reporter: Christian Schneider
• Created: 09/Apr/15 17:02
• Updated: 09/Feb/17 12:15
• Resolved: 13/Oct/16 06:41

Description

ResolverImpl currently contains about 2300 lines of code. That is way too big for a single class.

I looked into it and found that the checkDynamicPackageSpaceConsistency and checkPackageSpaceConsistency methods and their dependent methods form a nice subset. I would move that into a class ConsistencyCheck.

Both would share all of the inner classes of ResolverImpl but nothing else.
So I think i would make sense to move these inner classes to separate files.

These changes should nicely split the classes into
ResolverImpl : 1400 lines
ConsistencyCheck : 600 lines

Issue Links

• links to: GitHub Pull Request #18