[FELIX-4663] Potential memory leak in AsyncDeliveryTask

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: eventadmin-1.3.2
• Fix Version/s: eventadmin-1.4.4
• Component/s: Event Admin
• Assignee: Carsten Ziegeler
• Reporter: Hartmut Lang
• Created: 03/Oct/14 09:02
• Updated: 10/Aug/15 06:58
• Resolved: 06/Oct/14 12:18

Description

EventAdmin 1.3.2 can create an OutOfMemory condition caused by not delivered async events.
The problem can occur if an interrupted thread issues an async event (e.g. log-event).
In EventAdmin 1.3.2 the async-delivery uses DefaultThreadPool based on PooledExecutor.
If the already interrupted thread enters the execute-method in PooledExecutor an InterruptedException is thrown before the TaskExecutor was added to the Thread-Pool.
This Exception is catched(not handled, only logged) in the DefaultThreadPool.
As a result the TaskExecuter was not scheduled in the ThreadPool but is still part of the m_running_threads.
All new events are added to the pool of the TaskExecuter, adding in a increasing LinkedList. The TaskExecutor is never started again. Memory is leaking.
Seems that 1.4.x is not vulnerable related to interrupted threads. But the same catch-and-not-handle block is used in 1.4.x.