[FELIX-4410] Exceptions during rollback are not always properly handled

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: deploymentadmin-0.9.5
• Fix Version/s: deploymentadmin-0.9.6
• Component/s: Deployment Admin
• Assignee: Unassigned
• Reporter: Marcel Offermans
• Created: 28/Jan/14 14:53
• Updated: 01/Apr/14 12:45
• Resolved: 03/Feb/14 13:14

Description

In DeploymentSessionImpl.call(...) there are a couple of locations that trigger a rollback. It is currently possible for the rollback itself to create an exception. Not all commands that participate in the rollback currently catch all such exceptions. The spec describes in 114.7.1 that the rollback should always do its best to reverse all effects, and log any problems it ran into. We should make a better effort to do so. Therefore I suggest a review of all those commands where we explicitly check thrown exceptions and deal with them.