[FELIX-4345] Add support for IPv4 and IPv6 addresses for console

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: gogo.shell-0.10.0
• Component/s: Gogo Shell
• Assignee: Unassigned
• Reporter: Alex Blewitt
• Created: 05/Dec/13 23:28
• Updated: 19/Jan/16 14:34
• Resolved: 19/Jan/16 14:34

Description

The telnetd server only listens to IPv4 or IPv6 because the default value for the --ip parameter is "".

Even though 'localhost' resolves to both ::1 and 127.0.0.1, passing in "" for the address results in it picking one of them.

If the value is 'null' for the IP address then it will resolve and bind to both network addresses.

The bug is here:

118 server = new ServerSocket(port, 0, InetAddress.getByName(ip));

This should be:

InetAddress address = "".equals(ip) ? null : InetAddress.getByName(p);
118 server = new ServerSocket(port, 0, address);