[FELIX-4013] Incorrect usage of ServiceTracker.size() in UPnP Plugin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: webconsole-upnp-plugin-1.0.2
• Fix Version/s: webconsole-upnp-plugin-1.0.4
• Component/s: Web Console
• Assignee: Valentin Valchev
• Reporter: Valentin Valchev
• Created: 03/Apr/13 17:53
• Updated: 05/Jan/15 12:47
• Resolved: 03/Apr/13 17:55

Description

There seems to be a small problem with the tracking code especially with the following line (Activator.java):

if (tracker.size() <= 1 && plugin != null)

...
ServiceTrackerCustomizer.removedService() is supposed to be called AFTER the service is no longer tracked. So in that method the size must be already decremented. The code above will unregister the plugin if only one UPnP device left in the system and it wouldn't be accessible through the web console.

The correct code is:

if (tracker.size() == 0 && plugin != null)