[FELIX-3987] ResourceServlet sets content-length header too late

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: http-2.2.0
• Fix Version/s: http-2.2.2
• Component/s: HTTP Service
• Assignee: J.W. Janssen
• Reporter: Kaspar von Gunten
• Created: 21/Mar/13 15:33
• Updated: 01/Aug/15 09:22
• Resolved: 11/Nov/13 14:24

Description

The ResourceServlet.handle(..) implementation sets content-type and last-modified headers, then goes on and copies the specified resource's content onto the response's output stream. When it is done, it sets the content-length header to the # of written bytes.

This is just wrong, because all headers should be present before content is written. The implementation gets away with it, because most content probably fits into the internal buffers and content-length is set before flush/close is called, but with large content this will cause problems.

Suggestion: determine content-length in handle (analogous to last-modified) BEFORE calling copy(). I attached a suggested patch for the v2.2.0 ResourceServlet.