[FELIX-3986] ThreadDumper comparators are not correctly implemented

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: webconsole-4.0.0
• Fix Version/s: webconsole-4.2.0
• Component/s: Web Console
• Assignee: Valentin Valchev
• Reporter: Valentin Valchev
• Created: 21/Mar/13 15:06
• Updated: 06/Jun/13 15:34
• Resolved: 21/Mar/13 15:08

Description

The ThreadComparator and ThreadGroupComparator do not handle correctly null values. In embedded java SE 7 it might cause the following exception:

java.lang.IllegalArgumentException: Comparison method violates its general contract!
at java.util.TimSort.mergeHi(TimSort.java:868)
at java.util.TimSort.mergeAt(TimSort.java:485)
at java.util.TimSort.mergeCollapse(TimSort.java:408)
at java.util.TimSort.sort(TimSort.java:214)
at java.util.TimSort.sort(TimSort.java:173)
at java.util.Arrays.sort(Arrays.java:659)
at org.apache.felix.webconsole.internal.misc.ThreadDumper.printThreadGroup(ThreadDumper.java:161)