[FELIX-3946] NullPointerException in BundleServlet.bundleDetails when not called through HTTP

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: webconsole-4.2.0
• Fix Version/s: webconsole-4.2.0
• Component/s: Web Console
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 04/Mar/13 07:52
• Updated: 06/Jun/13 15:34
• Resolved: 04/Mar/13 08:04

Description

With the introduction of the Inventory bundle and the migration of ConfigurationStatusPrinter to InventoryPrinter, these services may be called through other channels than through the Web Console over HTTP.

Thus the appRoot and pluginRoot parameters to the BundleServlet.writeJSON method may be null and therefore the following code in the bundleDetails method throws a NullPointerException:

> bundleInfoDetails(jw, bundle, pluginRoot.substring(0, pluginRoot.lastIndexOf("/")), locale);

A number of fixes are required:

• Prevent NPE at this code location
• Clarify BundleInfoProvider interface that webConsoleRoot may be null
• Fix ServicesUsedInfoProvider to create VALUE type BundleInfo if webConsoleRoot is null