[FELIX-3743] Potential endless loop setting the active framework startlevel

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: framework-4.0.2
• Fix Version/s: framework-4.2.0
• Component/s: Framework
• Assignee: Felix Meschberger
• Reporter: Felix Meschberger
• Created: 01/Nov/12 08:27
• Updated: 04/Jun/14 09:55
• Resolved: 01/Nov/12 08:39

Description

We experience an issue with setting the framework startlevel in the Felix.setActiveStartLevel(int, FrameworkListener[]) method.

On line 1216 the bundle lock is acquired. If this fails with an IllegalStateException the loop just continues. But the bundle remains in the m_startLevelBundles set and is retried later. In the case of an uninstalled bundle, this situation will not change and the method is probabl going into an endless loop.

Would it make sense to remove the bundle from the m_startLevelBundles set in the catch block starting line 1223 if the bundle has been uninstalled ?

Proposed patch:

Index: Felix.java
===================================================================
— Felix.java (revision 1404016)
+++ Felix.java (working copy)
@@ -1227,6 +1227,14 @@
Logger.LOG_ERROR,
"Error locking " + tuple.m_bundle._getLocation(), ex);
}
+ else
+ {
+ synchronized (m_startLevelBundles)
+

{ + m_startLevelBundles.remove(tuple); + bundlesRemaining = !m_startLevelBundles.isEmpty(); + }

+ }
continue;
}

Issue Links

• is duplicated by: FELIX-4527 Infinite loop when bundle is undeployed "coldly" (when container is stopped)