[FELIX-3718] [DS] deactivate might not move component state to unsatisfied

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: scr-1.8.0
• Fix Version/s: scr-1.6.2
• Component/s: Declarative Services (SCR)
• Assignee: David Jencks
• Reporter: David Jencks
• Created: 18/Oct/12 04:52
• Updated: 20/Nov/12 10:58
• Resolved: 18/Oct/12 06:20

Description

After deactivating, we check to see if the state changed before moving to unsatisfied:

if ( acm.state() == this )

{ acm.changeState( Unsatisfied.getInstance() ); }

But the state might have been moved from Active to Registered meanwhile, so deactivate would leave us in the Registered state. Instead, check if the state is a satisfied state, and if so, move it to unsatisfied.