[FELIX-3582] finalName not properly populated in maven-bundle-plugin with buildnumber-maven-plugin

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: maven-bundle-plugin-2.3.7
• Fix Version/s: maven-bundle-plugin-2.4.0
• Component/s: Maven Bundle Plugin
• Labels: patch
• Assignee: Unassigned
• Reporter: Jason Woodrich
• Created: 03/Jul/12 22:36
• Updated: 12/Jun/13 23:46
• Resolved: 07/Jun/13 20:01

Description

If the finalName element in the build section contains elements that are dynamically populated, such as ${buildNumber}, and the packaging element is set to bundle, the literal string "${buildNumber}" will appear in the jar file that's produced. I took a look at the source code and found what I believe to be the problem and applied a fix in a local copy of the source code. In org/apache/felix/bundleplugin/BundleInfo.java:1113 there is this line of code:

String finalName = currentProject.getBuild().getFinalName();

I removed this line (1113) and added the following near the top of the class:

/**

• Name of the generated JAR.
• @parameter alias="jarName" expression="${jar.finalName}" default-value="${project.build.finalName}"
• @required
  */
  private String finalName;

This properly populates the finalName in the jar file and all of the unit tests pass. I'm not sure if this affects anything else but as far as I can tell it doesn't.