[FELIX-3428] NPE in UPnP Web Console Plugin (again)

• Type: Bug
• Status: Resolved
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: webconsole-upnp-plugin-1.0.0
• Fix Version/s: webconsole-upnp-plugin-1.0.2
• Component/s: Web Console
• Assignee: Valentin Valchev
• Reporter: Valentin Valchev
• Created: 04/Apr/12 07:01
• Updated: 04/Apr/12 07:03
• Resolved: 04/Apr/12 07:03

Description

If there is invalid UPnP device, that has no registration properties, the UPnP Plugin will throw:

upnp>$java.lang.NullPointerException
at org.apache.felix.webconsole.plugins.upnp.internal.ControlServlet.deviceTreeToJSON(ControlServlet.java:236)
at org.apache.felix.webconsole.plugins.upnp.internal.ControlServlet.doPost(ControlServlet.java:140)
at org.apache.felix.webconsole.plugins.upnp.internal.WebConsolePlugin.doPost(WebConsolePlugin.java:102)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:722)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:815)

Besides that, the valid devices will not be rendered in the web console too. So iyou need to have ONE bad UPnP device, to break everything.