[FELIX-3427] NPE in UPnP Web Console Plugin

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: webconsole-upnp-plugin-1.0.0
• Fix Version/s: webconsole-upnp-plugin-1.0.2
• Component/s: Web Console
• Assignee: Valentin Valchev
• Reporter: Valentin Valchev
• Created: 03/Apr/12 16:26
• Updated: 03/Apr/12 16:29
• Resolved: 03/Apr/12 16:29

Description

Some buggy implementation might return invalid image stream (null) and this will cause the following NPE in web console:

fw>$19:20:59.667 ERROR - [HTTP] Problem while making answer to request /system/console/upnp from client address null prosyst.mbs.httpjsp.?():?
java.lang.NullPointerException
at org.apache.felix.webconsole.plugins.upnp.internal.ControlServlet.doGet(ControlServlet.java:109)
at org.apache.felix.webconsole.plugins.upnp.internal.WebConsolePlugin.doGet(WebConsolePlugin.java:119)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:702)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:815)
at org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:493)
at org.apache.felix.webconsole.internal.servlet.OsgiManager.service(OsgiManager.java:418)
at com.prosyst.mbs.impl.services.http.ServletProperties.service(ServletProperties.java:109)
at com.prosyst.mbs.impl.services.http.Response.defaultResponse(Response.java:353)
at com.prosyst.mbs.impl.services.http.FiltersManagerImpl.dispatch(FiltersManagerImpl.java:183)
at com.prosyst.mbs.impl.services.http.FiltersFactory.dispatch(FiltersFactory.java:38)
at com.prosyst.mbs.impl.services.http.Response.makeAnswer(Response.java:181)
at com.prosyst.mbs.impl.services.http.ThreadProcess.run(ThreadProcess.java:112)
at com.prosyst.util.impl.tpt.threadpool.ExecutorImpl.run(ExecutorImpl.java:191)

Instead of that NPE web console should return 404 status.