[FELIX-3383] FileInstall ConfigInstaller does not check filter syntax which will lead bundle start failure when felix installation directory including one of these characters ( )

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Component/s: File Install
• Environment: Ubuntu 10.04; Oracle jdk 6
• Assignee: Unassigned
• Reporter: Ming Xia
• Created: 10/Mar/12 18:31
• Updated: 15/Mar/12 16:45
• Resolved: 15/Mar/12 16:45

Description

This piece of code in ConfigInstaller.java could throw InvalidSyntaxException, then lead bundle start failure or unusable when the fileName string include one of these characters: ( )

Configuration findExistingConfiguration(String fileName) throws Exception
{
String filter = "(" + DirectoryWatcher.FILENAME + "=" + fileName + ")";
Configuration[] configurations = getConfigurationAdmin().listConfigurations(filter);
if (configurations != null && configurations.length > 0)

{ return configurations[0]; }

else

{ return null; }

}

According to the OSGi specification 3.2.7 Filter Syntax:

If value must contain one of the characters '\', '*', '(' or ')', then these characters
should be preceded with the backslash ('\') character.

fileName string could include ( or ), for example, the server is installed in a folder on windows like "C:\Program files (x86)\appserver", then the server will fail to start.

Issue Links

• blocks: KARAF-1127 Boot features failed to startup when karaf started from directory with closing brace; logs also unavailable
• is duplicated by: FELIX-3396 Fileinstall is not able to handle configuration file if in a path containing braces
• relates to: GERONIMO-6277 Server cannot start if the installation path includes parenthesis character "(" or ")"