Felix
  1. Felix
  2. FELIX-3268

Cannot build webconsole and webconsole-plugins with JDK 7

    Details

      Description

      A search in JIRA returned no match for "native2ascii" and no relevant match for "native", so I'm creating an issue.

      When trying to build Felix SVN HEAD with JDK 7, the build process stops when it fails to invoke native2ascii in webconsole.
      It seems that there was a change between JDK 6 and JDK 7, and the 1.0-alpha-1 version of org.codehaus.mojo:native2ascii-maven-plugin in multiple POMs cannot handle it. However, version 1.0-beta-1 (I obtained that version number by removing the "version" parameter entirely) can cope with JDK 7.
      The patch below fixes the build problem in webconsole & webconsole-plugins:

      diff --git a/webconsole-plugins/deppack/pom.xml b/webconsole-plugins/deppack/pom.xml
      index 0c764e6..e576a57 100644
      — a/webconsole-plugins/deppack/pom.xml
      +++ b/webconsole-plugins/deppack/pom.xml
      @@ -40,7 +40,7 @@
      <plugin>
      <groupId>org.codehaus.mojo</groupId>
      <artifactId>native2ascii-maven-plugin</artifactId>

      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>
        diff --git a/webconsole-plugins/ds/pom.xml b/webconsole-plugins/ds/pom.xml
        index 40a3224..338f306 100644
          • a/webconsole-plugins/ds/pom.xml
            +++ b/webconsole-plugins/ds/pom.xml
            @@ -40,7 +40,7 @@
            <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>native2ascii-maven-plugin</artifactId>
      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>
        diff --git a/webconsole-plugins/event/pom.xml b/webconsole-plugins/event/pom.xml
        index b257032..2375eab 100644
          • a/webconsole-plugins/event/pom.xml
            +++ b/webconsole-plugins/event/pom.xml
            @@ -48,7 +48,7 @@
            <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>native2ascii-maven-plugin</artifactId>
      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>
        diff --git a/webconsole-plugins/obr/pom.xml b/webconsole-plugins/obr/pom.xml
        index c4a88f2..3854ca3 100644
          • a/webconsole-plugins/obr/pom.xml
            +++ b/webconsole-plugins/obr/pom.xml
            @@ -40,7 +40,7 @@
            <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>native2ascii-maven-plugin</artifactId>
      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>
        diff --git a/webconsole-plugins/shell/pom.xml b/webconsole-plugins/shell/pom.xml
        index 661d3cd..7f1b428 100644
          • a/webconsole-plugins/shell/pom.xml
            +++ b/webconsole-plugins/shell/pom.xml
            @@ -40,7 +40,7 @@
            <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>native2ascii-maven-plugin</artifactId>
      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>
        diff --git a/webconsole-plugins/upnp/pom.xml b/webconsole-plugins/upnp/pom.xml
        index 413da08..bb091a4 100644
          • a/webconsole-plugins/upnp/pom.xml
            +++ b/webconsole-plugins/upnp/pom.xml
            @@ -48,7 +48,7 @@
            <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>native2ascii-maven-plugin</artifactId>
      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>
        diff --git a/webconsole/pom.xml b/webconsole/pom.xml
        index bf4e1cb..b9f0db2 100644
          • a/webconsole/pom.xml
            +++ b/webconsole/pom.xml
            @@ -69,7 +69,7 @@
            <plugin>
            <groupId>org.codehaus.mojo</groupId>
            <artifactId>native2ascii-maven-plugin</artifactId>
      • <version>1.0-alpha-1</version>
        + <version>1.0-beta-1</version>
        <executions>
        <execution>
        <goals>

        Activity

        Hide
        Felix Meschberger added a comment -

        Thanks for providing the patch. I have applied it in Rev. 1215489

        Show
        Felix Meschberger added a comment - Thanks for providing the patch. I have applied it in Rev. 1215489
        Hide
        Lionel Debroux added a comment -

        I've just tried to recompile Felix from the trunk (r1221765), and the build failed in webconsole-plugins/event, because the pom.xml still contains a dependence on org.codehaus.mojo:native2ascii-maven-plugin:1.0-alpha-1. The other pom.xml files are OK, though.

        Show
        Lionel Debroux added a comment - I've just tried to recompile Felix from the trunk (r1221765), and the build failed in webconsole-plugins/event, because the pom.xml still contains a dependence on org.codehaus.mojo:native2ascii-maven-plugin:1.0-alpha-1. The other pom.xml files are OK, though.
        Hide
        Valentin Valchev added a comment -

        The new native2ascii-maven-plugin actually does nothing. So localization is missing. My own plugins (build with ant) are localized correctly, but webconsole - doesn't show in the language I choose.

        I looked at the jar file and it seems, that doesn't include any extra resources besides bundle.properties

        Show
        Valentin Valchev added a comment - The new native2ascii-maven-plugin actually does nothing. So localization is missing. My own plugins (build with ant) are localized correctly, but webconsole - doesn't show in the language I choose. I looked at the jar file and it seems, that doesn't include any extra resources besides bundle.properties
        Hide
        Felix Meschberger added a comment -

        Looks like the 1.0-beta-1 version actually expects the files to be in the standard source location and not in a separate tree.

        Moving the files to src/main/resources solves the problem.

        Show
        Felix Meschberger added a comment - Looks like the 1.0-beta-1 version actually expects the files to be in the standard source location and not in a separate tree. Moving the files to src/main/resources solves the problem.
        Hide
        Felix Meschberger added a comment -

        Moved the resources to src/main/resources in Rev. 1305413 and updated the event plugin to use 1.0-beta-1 of the native2ascii plugin in Rev. 1305415

        Show
        Felix Meschberger added a comment - Moved the resources to src/main/resources in Rev. 1305413 and updated the event plugin to use 1.0-beta-1 of the native2ascii plugin in Rev. 1305415
        Hide
        Felix Meschberger added a comment -

        Resolving as fixed after removing empty folders in Rev. 1305472

        Show
        Felix Meschberger added a comment - Resolving as fixed after removing empty folders in Rev. 1305472
        Hide
        Felix Meschberger added a comment -

        Close after release

        Show
        Felix Meschberger added a comment - Close after release

          People

          • Assignee:
            Felix Meschberger
            Reporter:
            Lionel Debroux
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development