[FELIX-3214] Gogo shell bundle should not shut down the framework by default

• Type: Improvement
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: Gogo Shell
• Assignee: Unassigned
• Reporter: Glyn Normington
• Created: 10/Nov/11 12:00
• Updated: 10/Nov/11 12:01

Description

Embedding the Gogo shell in Eclipse Virgo, we have found it necessary to set an appropriate property to prevent the Shell class from shutting down the whole OSGi framework. This behaviour is rather anti-social from the perspective of embedding Gogo. It means we need to set the relevant property, e.g. gosh.args=--nointeractive, for each and every way of launching the Virgo kernel (Startup script, from Eclipse, from integration test framework, from other test frameworks, etc.). Each time someone launches the Virgo kernel in a new way, they are likely to hit this gotcha as it is pretty surprising.

The relevant code is in the Shell class:

if (login && interactive && !opt.isSet("noshutdown"))
       

{            System.out.println("gosh: stopping framework");            shutdown();        }

This affects version 0.8.0 of Gogo.

(It is, of course, conceivable we are using Gogo incorrectly, in which case this issue can be used to improve the relevant Gogo documentation.)