Uploaded image for project: 'Felix'
  1. Felix
  2. FELIX-290

ConcurrentModificationException during transformDirectives

    XMLWordPrintableJSON

Details

    Description

      While adding some extra unit tests to the maven-bundle-plugin, I was able to cause a ConcurrentModificationException during transformDirectives:

      java.util.ConcurrentModificationException
      at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1031)
      at java.util.TreeMap$EntryIterator.next(TreeMap.java:1052)
      at java.util.TreeMap$EntryIterator.next(TreeMap.java:1050)
      at org.apache.felix.tools.maven2.bundleplugin.BundlePlugin.transformDirectives(BundlePlugin.java:127)
      at org.apache.felix.tools.maven2.bundleplugin.BundlePlugin.execute(BundlePlugin.java:151)
      at org.apache.felix.tools.maven2.bundleplugin.BundlePlugin.execute(BundlePlugin.java:115)
      at org.apache.felix.tools.maven2.bundleplugin.BundlePlugin.execute(BundlePlugin.java:110)
      at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:443)
      at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoals(DefaultLifecycleExecutor.java:539)
      at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalWithLifecycle(DefaultLifecycleExecutor.java:480)
      at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoal(DefaultLifecycleExecutor.java:459)
      at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeGoalAndHandleFailures(DefaultLifecycleExecutor.java:311)
      at org.apache.maven.lifecycle.DefaultLifecycleExecutor.executeTaskSegments(DefaultLifecycleExecutor.java:278)
      at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:143)
      at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:334)
      at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:125)
      at org.apache.maven.cli.MavenCli.main(MavenCli.java:272)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:585)
      at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315)
      at org.codehaus.classworlds.Launcher.launch(Launcher.java:255)
      at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430)
      at org.codehaus.classworlds.Launcher.main(Launcher.java:375)

      this is due to extra keys being added during the iteration (mea culpa) - I've produced a patch with the failing test, plus corrected transformation code.

      Attachments

        1. FELIX-290-20070518-PROPOSED-FIX.patch
          2 kB
          Stuart McCulloch
        2. FELIX-290-20070518-UNIT-TEST.patch
          2 kB
          Stuart McCulloch

        Activity

          People

            rickhall Richard S. Hall
            mcculls Stuart McCulloch
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: