[FELIX-2882] It's dangerous to use service instances as keys in a Map (in the http whiteboard bundle).

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: http-2.2.0
• Fix Version/s: http-2.2.1
• Component/s: HTTP Service
• Assignee: Felix Meschberger
• Reporter: Marcel Offermans
• Created: 16/Mar/11 23:26
• Updated: 28/Sep/13 17:40
• Resolved: 05/Dec/11 20:30

Description

In ExtenderManagerImpl.addMapping() the key that is used to store a tuple in a Map is actually the service instance that you get from the ServiceTracker. This is dangerous because you have absolutely no idea if that instance correctly implements equals() and hashCode(). It's usually better to use the ServiceReference as the key (which is guaranteed to correctly implement those methods). It's probably only a minor issue in practice, but still one you can look for a long time if it does bite you.