[FELIX-2772] setting http.port=-1 should disable service rather than throw exception

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: http-2.0.4
• Fix Version/s: http-2.2.0
• Component/s: HTTP Service
• Assignee: Felix Meschberger
• Reporter: Derek Baum
• Created: 09/Jan/11 10:41
• Updated: 09/Jan/11 19:37
• Resolved: 09/Jan/11 18:15

Description

I want to stop http.jetty from starting automatically, as I want to ensure the correct port is first explicitly configured using config admin.

I can currently do this by setting org.apache.felix.http.enable=false, but this then complicates starting the service, as I have to set both http.enable=true and http.port=PORT

It would be useful if setting http.port=-1 effectively disabled the service, then just by using config admin to set a valid port the service would start. Currently setting http.port=-1 results in the following exception:

[WARNING] failed SelectChannelConnector@0.0.0.0:-1: java.lang.IllegalArgumentException: port out of range:-1
[WARNING] failed Server@1f195fc: java.lang.IllegalArgumentException: port out of range:-1

[ERROR] Exception while initializing Jetty.
java.lang.IllegalArgumentException: port out of range:-1
at java.net.InetSocketAddress.<init>(InetSocketAddress.java:83)

The Equinox http service is disabled if http.port=-1